-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track flutter version in a file #308
Conversation
8fb097b
to
61ac921
Compare
61ac921
to
38d4ce8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed a typo.
also switched the key to _doc to make it more obvious that it is not a key to be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really enjoyed the json trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contrary to Carlos, I’m not a big fan to allow the nesting trick, especially if this starts to be abuse setting version per-platform (the simplest, the better, we should just align). However, let’s see how it goes in practice, and I hope this will not going to be used.
Nicely done! I think we can at the next physicial sprint gather and propose it for our common repo!
{
"why": {
"would": {
"you": {
"not": {
"love": {
"this?"
}
}
}
}
}
} 😆 Agree on avoiding abusing this, but it can occasionally be useful, particularly because this action can be used to load any arbitrary data without much effort. |
This also leaves the door open for tracking any other version or value we want.
How to use it
Go to
tools/versions.json
and append your entry:To use it:
Nested data!
You can nest keys:
then access them:
UDENG-1500