ci(gh-actions): Migrate actions to desktop engineering's #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardGomezEscandell
force-pushed
the
migrate-actions-desktop-engineering
branch
15 times, most recently
from
d3a05f7 to
91694e8
Compare
EduardGomezEscandell
changed the title
EduardGomezEscandell
force-pushed
the
migrate-actions-desktop-engineering
branch
10 times, most recently
from
d105082 to
cd6d6d6
Compare
|
Only failure is now the fact that we need to upgrade to 1.21.1 to fix a couple vulnerabilities. |
EduardGomezEscandell
force-pushed
the
migrate-actions-desktop-engineering
branch
2 times, most recently
from
b7ff27a to
8ffe45f
Compare
EduardGomezEscandell
force-pushed
the
migrate-actions-desktop-engineering
branch
6 times, most recently
from
1110427 to
3a7709f
Compare
didrocks
previously approved these changes
Oct 5, 2023
There was a problem hiding this comment.
phew, for a second, I was afraid about the diff itself (more lines in than out for a refactoring), but I just realize that we were not doing as much check as we did and now, we are up to the same quality standard than adsys and authd in term of checking code! Nicely done :)
Desktop engineerings Go/code-sanity already includes this check, so no need to repeat it ourselves
This code will sonner or later move away from this repo, so no need to run and maintain Windows gRPC generation.
Let's use the package name in the matrix and pre-append the path when necessary.
EduardGomezEscandell
force-pushed
the
migrate-actions-desktop-engineering
branch
from
3a7709f to
cd554a7
Compare
|
Force-pushed to solve conflicts after having merged #308. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDENG-1399