Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate race in wslinstance's TestConnected #279

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Mitigate race in wslinstance's TestConnected #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion windows-agent/internal/proservices/wslinstance/wslinstance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ func stopWSLClientOnMatchingStep(wantStopStep, currentStep step, wsl *wslDistroM
func checkConnectedStatus(t *testing.T, wantDoneStep step, wantErr bool, currentStep step, srv wrappedService) (continueTest bool) {
t.Helper()

connectedErr, stopped := srv.wait(100 * time.Millisecond)
connectedErr, stopped := srv.wait(300 * time.Millisecond)
if currentStep != wantDoneStep {
require.False(t, stopped, "Connect() function should still be running at step %q but is has now stopped (should stop at step %q)", currentStep, wantDoneStep)
return true
Expand Down
Loading