Mitigate race in wslinstance's TestConnected #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardGomezEscandell
force-pushed
the
fix-TestConnected-race
branch
2 times, most recently
from
c979dfc to
3af479f
Compare
EduardGomezEscandell
force-pushed
the
fix-TestConnected-race
branch
from
3af479f to
9bfb02e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a home-cooked version of
Eventually. These kind of checks are never reace-safe, you can only increase your confidence by increasing timeouts.Since Github machines seem to run quite a bit slower than my local dev machine, I sometimes underestimate the length of timeouts. Hopefully this is the case here.
UDENG-1382