Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing MAAS UI e2e tests #5198

Merged
merged 12 commits into from
Oct 25, 2023
Merged

test: fix failing MAAS UI e2e tests #5198

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0aa904d
add timeout and check if button is emabled
Jay-Topher Oct 17, 2023
ed50207
TEMPORARY: get cypress tests running
Jay-Topher Oct 17, 2023
2f70fa1
undo button enable check
Jay-Topher Oct 24, 2023
9f93215
add check to make sure image is synced fully
Jay-Topher Oct 24, 2023
b5cfe33
remove duplicate commands
Jay-Topher Oct 24, 2023
9f2ae19
update footer tests
Jay-Topher Oct 24, 2023
907a1c4
add submit button click
Jay-Topher Oct 24, 2023
dd33e8d
run cypress tests on main and 3.x
Jay-Topher Oct 24, 2023
83992b9
separate image syncing script
Jay-Topher Oct 25, 2023
ddebb85
testrun cypress on push
Jay-Topher Oct 25, 2023
7bd2acc
run cypress on push to main
Jay-Topher Oct 25, 2023
51f19fd
rename process
Jay-Topher Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/cypress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
run: |
export API_KEY=`sudo maas apikey --username=admin`
maas login admin http://localhost:5240/MAAS $API_KEY
while [ $(maas admin boot-resources is-importing | cat) == "true" ]; do sleep 10; done; echo "syncing finished"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally it should be moved to a separate step (e.g. with a name "Wait for MAAS boot resources") which would help track its progress (and execution time).

maas admin users create username=user password=test [email protected] is_superuser=0
- name: Run Cypress tests with a user
uses: cypress-io/github-action@v4
Expand Down
13 changes: 9 additions & 4 deletions cypress/e2e/with-users/base/footer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,22 @@ context("Footer", () => {
});

it("navigates to the local documentation", () => {
cy.get(".p-footer__link:contains(Local documentation)").click();
cy.location("pathname").should("eq", "/MAAS/docs/");
cy.findByRole("link", { name: /local documentation/i })
.should("have.attr", "href")
.and("include", "/MAAS/docs/");
});

it("has a link to legal", () => {
cy.get(".p-footer__link:contains(Legal information)")
cy.findByRole("link", {
name: /legal information/i,
})
.should("have.attr", "href")
.and("include", "https://www.ubuntu.com/legal");
});

it("displays the feedback link", () => {
cy.get(".p-footer__nav button:contains(Give feedback)").should("exist");
cy.findByRole("button", {
name: /give feedback/i,
}).should("exist");
});
});
2 changes: 1 addition & 1 deletion cypress/support/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Cypress.Commands.add("addMachine", (hostname = generateName()) => {
cy.get("input[name='hostname']").type(hostname);
cy.get("input[name='pxe_mac']").type(generateMac());
cy.get("select[name='power_type']").select("manual").blur();
cy.get("button[type='submit']").click();
cy.findByRole("button", { name: /save machine/i }).click();
cy.get(`[data-testid='message']:contains(${hostname} added successfully.)`, {
timeout: LONG_TIMEOUT,
});
Expand Down