test: fix failing MAAS UI e2e tests #5198
Conversation
|
Demo starting at https://maas-ui-5198.demos.haus |
|
@Jay-Topher Changes that are related to tests only are usually prefixed with |
cypress/support/commands.ts
Outdated
| cy.get("button[type='submit']", { timeout: LONG_TIMEOUT }) | ||
| .should("be.enabled") | ||
| .click(); |
There was a problem hiding this comment.
As explained in the acceptance criteria, our goal here is to:
Wait for ephemeral OS to be available or provide a workaround allowing the test to pass when it’s unavailable
Generic timeout wait specific enough. I'd recommend to talk to someone from the MAAS core team, share a screenshot of the failing test where ephemeral message is visible and find if there are better ways of detecting this.
There was a problem hiding this comment.
Okay, thanks I reach out to someone concerning this, this is not up for review yet, I created a draft PR as a sandbox to get Cypress test results.
Jay-Topher
force-pushed
the
MAASENG-1967-fix-maas-ui-e2e-tests
branch
from
703df95 to
b5cfe33
Compare
Jay-Topher
changed the title
.github/workflows/cypress.yml
Outdated
| @@ -36,6 +36,7 @@ jobs: | |||
| run: | | |||
| export API_KEY=`sudo maas apikey --username=admin` | |||
| maas login admin http://localhost:5240/MAAS $API_KEY | |||
| while [ $(maas admin boot-resources is-importing | cat) == "true" ]; do sleep 10; done; echo "syncing finished" | |||
There was a problem hiding this comment.
I think ideally it should be moved to a separate step (e.g. with a name "Wait for MAAS boot resources") which would help track its progress (and execution time).
Done
QA steps
Fixes
1967
Fixes: