scripts: Fix net-istio version for 1.9 scanning #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimonas Sotirchos <[email protected]>
DnPlas
reviewed
Aug 23, 2024
kimwnasptd
force-pushed
the
KF-6140-fix-image-gather-script
branch
from
22833f6 to
c76d750
Compare
DnPlas
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Looking good overall, just two tiny nits. Thanks @kimwnasptd !
Co-authored-by: Daniela Plascencia <[email protected]>
mvlassis
pushed a commit
that referenced
this pull request
Sep 4, 2024
* scripts: Fix net-istio version for 1.9 scanning Signed-off-by: Kimonas Sotirchos <[email protected]> * Add CONTRIBUTING.md * Hardcode the net istio version * Update CONTRIBUTING.md Co-authored-by: Daniela Plascencia <[email protected]> * review: Add extra message for where to look for net-istio * fix typo --------- Signed-off-by: Kimonas Sotirchos <[email protected]> Co-authored-by: Daniela Plascencia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219
The PR hardcodes the version of net-istio to be used for the 1.12.4 version of Knative Service (used in CKF 1.9), similarly to how we handled it for CKF 1.8.
To verify: