Skip to content

Commit

Permalink
Hardcode the net istio version
Browse files Browse the repository at this point in the history
  • Loading branch information
kimwnasptd committed Aug 29, 2024
1 parent 0e6b952 commit c76d750
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions tools/get-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,10 @@ wget -q "${KNATIVE_SERVING_REPO_DOWNLOAD_URL}/knative-v${KNATIVE_SERVING_VERSION
SERVING_IMAGE_LIST+=($(yq -N '.spec.template.spec.containers | .[] | .image' ./serving-storage-version-migration.yaml))
wget -q "${KNATIVE_SERVING_REPO_DOWNLOAD_URL}/knative-v${KNATIVE_SERVING_VERSION}/serving-post-install-jobs.yaml"
SERVING_IMAGE_LIST+=($(yq -N '.spec.template.spec.containers | .[] | .image' ./serving-post-install-jobs.yaml))
# obtain net istio images based on hardcoded version
NET_ISTIO_VERSION="${KNATIVE_SERVING_VERSION}"
# NOTE: for KNative Serving version 1.10.2 Net Istio version must be set to 1.11.0
# this need to be reviewed if KNative Serving version is changed
if [ $KNATIVE_SERVING_VERSION == "1.10.2" ]; then
NET_ISTIO_VERSION="1.11.0"
fi

# For Serving 1.12.4 (CKF 1.9) we have to use 1.12.3 for net-istio
# https://github.com/kubeflow/manifests/pull/2709
if [ $KNATIVE_SERVING_VERSION == "1.12.4" ]; then
NET_ISTIO_VERSION="1.12.3"
fi

NET_ISTIO_VERSION="1.12.3"
NET_ISTIO_REPO_DOWNLOAD_URL=https://github.com/knative-extensions/net-istio/releases/download/
NET_ISTIO_IMAGE_LIST=()
wget -q "${NET_ISTIO_REPO_DOWNLOAD_URL}knative-v${NET_ISTIO_VERSION}/net-istio.yaml"
Expand Down

0 comments on commit c76d750

Please sign in to comment.