r1.1 #31
Merged
r1.1 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adiness_Checklist.md
* Correct API Version and Release number * Changed absolute links to relative links (relative to repository root)
hdamker
requested review from
Kevsy,
crissancas and
javierlozallu
as code owners
Removed contact field Brought license and x-camara-commonalities fields on top level within info object. (hopefully done right)
making linter happy
indentation corrected (2. attempt)
All good thing are three ... removing trailing space
Incorporates changes listed in [SED camaraproject#32](camaraproject#32 (comment))
Kevsy
previously approved these changes
Jul 24, 2024
Changed from 'N' to 'Y' in the 'Previous public release was certified' column, with link to GSMA certification portal.
Confirmed that Enhanced API test cases are included ('rainy day' scenarios)
CHANGELOG.md
Outdated
| # r0.11.0-rc.1 | ||
| NOTE: SimpleEdgeDiscovery is part of the EdgeCloud API family, and was previously developed within the [EdgeCloud](https://github.com/camaraproject/EdgeCloud) repository. Two releases were made within EdgeCloud, v0.81 and r0.9.3-rc. These releases also include the other EdgeCloud APIs and materials, so the changelog below highlights only the changes related to SimpleEdgeDiscovery. Further information and links to the releases in EdgeCloud can be found below. | ||
|
|
||
| # r1.1 - public |
There was a problem hiding this comment.
it is not yet public - change public to rc in this header and in the toc item.
Suggest to remove line 20 (disclaimer)
There is no such thing as a public pre-release, hence the line 29 underneath should say "a release-candidate pre-release" iso "an initial public pre-release".
Line 39. suggest to reword as follows: "simple-edge-discovery v0.11.0-rc.1 is a new release-candidate version with significant changes compared to the previous version v0.9.3-rc"
documentation/API_documentation/SimpleEdgeDiscovery_User_Story.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/simple-edge-discovery_API_Readiness_Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/simple-edge-discovery_API_Readiness_Checklist.md
Show resolved
Hide resolved
Incorporated Tanja's changes: - changed 'public' to 'rc' in header and toc item - line 20 removed (disclaimer) - line 29 reworded as 'release candidate pre-release' - line 39 reworded to 'release candidate'
Per Tanja's review - moved `x-commonalities` beneath `version` field in `info` object
Incorporated Tanja's review feedback - removed 'EDS' - 'UE'-> 'device' - 'terminal' to 'device' - reworded scope line - removed 'UNI' line - 'MEC platform' -> 'Edge Cloud Zone' in diagram
Per Tanja review, updated link to User Story
Removed version number from `Feature` per Tanja's review comment for the API Readiness Checklist
Kevsy
previously approved these changes
Jul 26, 2024
Incorporated Tanja's review: - included link to pre-releases
Incorporated Tanja's additional comments from issue 32 - Commonalities v0.4-rc.1 -> v0.4.0-rc.1 - SED -> SimpleEdgeDiscovery
|
LGTM - From release mgmt perspective all is OK please update the API release tracker (and remove there the r1.1 in the public release field :-) ) almost there. |
Done - thanks Tanja and Herbert. @javierlozallu Release Management review confirmed (see above), now ready for merge to main. |
javierlozallu
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
none (minor PR)
Special notes for reviewers: