Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Management review #32

Closed
Kevsy opened this issue Jul 22, 2024 · 6 comments
Closed

Release Management review #32

Kevsy opened this issue Jul 22, 2024 · 6 comments
Assignees
Labels
subproject management Issues and PRs related to the management of the sub project

Comments

@Kevsy
Copy link
Contributor

Kevsy commented Jul 22, 2024

Problem description

Issue to request Release Management review of SimpleEdgeDiscovery 0.11.0-rc.1

Expected action

Release Management to kindly review PR #31 , to allow merge to main / release with tag r1.1

Additional context

@Kevsy Kevsy added the subproject management Issues and PRs related to the management of the sub project label Jul 22, 2024
@hdamker
Copy link
Contributor

hdamker commented Jul 22, 2024

In addition to #31 it is also necessary to rework the CHANGELOG.md, e.g.

  • change title of release towards r1.1
  • correct links accordingly so that they work with tag r1.1
  • change r1.4...r1.5 to something which works
  • if possible align the format more with the example within ReleaseManagement. The list of addressed issues might of less help
  • add some words about the history of the API and where the previous releases v0.8.1 and v0.9.3-rc can be found

Kevsy added a commit to hdamker/SimpleEdgeDiscovery that referenced this issue Jul 24, 2024
Incorporates changes listed in [SED camaraproject#32](camaraproject#32 (comment))
@tanjadegroot
Copy link

tanjadegroot commented Jul 25, 2024

CHANGELOG.md review - additional comments:

The API definition(s) are based on

  • Commonalities v0.4-rc.1 --> r0.4.0-rc.1 // missing the patch nr 0)
  • Identity and Consent Management v0.2.0-rc.1

NOTE: the ICM reference is OK (they will change to the correct release tag (r0.2.0-xx in the next (pre-)release)

There is still usage of "SED" on line 63 - recommend to use the full API name

@tanjadegroot
Copy link

README.md: needs to be updated:

  • include the link to the pre-release tag
  • include the link to the wiki

@tanjadegroot
Copy link

Need to do a last cross check with @hdamker on some commonalities and ICM checks needed, but it seem this is in great shape for M3.

@Kevsy
Copy link
Contributor Author

Kevsy commented Jul 26, 2024

Thanks for the review Tanja - additional comments above for CHANGELOG and README now committed.

@Kevsy
Copy link
Contributor Author

Kevsy commented Jul 29, 2024

Release Management review completion confirmed: #31 (comment)

@Kevsy Kevsy closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subproject management Issues and PRs related to the management of the sub project
Projects
None yet
Development

No branches or pull requests

3 participants