Issue #494: Add flag to control gesture continuity #599
Conversation
…eated as a new operation or simply discarded
vladcipariu91
added
enhancement
vladcipariu91
changed the title
| @@ -6,16 +6,24 @@ import com.bumble.appyx.interactions.core.ui.math.proportionOf | |||
|
|
|||
| open class Gesture<InteractionTarget, ModelState> internal constructor( | |||
| val operation: Operation<ModelState>, | |||
| val isContinuous: Boolean, | |||
There was a problem hiding this comment.
What do you think if we moved it to GestureFactory? That way it wouldn't need to be specified per every gesture. The cases we have so far are either all of them are continuous or all of them are not.
There was a problem hiding this comment.
the current option gives more control, however your suggestion is simpler to use, I would choose the existing one, but it's your call
There was a problem hiding this comment.
Can be a combination:
GestureFactoryprovides the defaultGesturefalls back to factory default but allows overriding if you want
There was a problem hiding this comment.
I'm assuming based on the cases so far that it's either/or for the whole of it, so if it's only one choice I'd go with factory-level definition for its ease.
There was a problem hiding this comment.
i'll update to only use on the factory
There was a problem hiding this comment.
@zsoltk done!
Issue
Description
Added
isContinuousBoolean flag toGesture. This is set totrueby default. However in cases where a new gesture being created with the remaining offset isn't desirable this can be set to false.Check list
CHANGELOG.mdif required.