Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow flag to control whether a gesture can be continuous #494

Closed
zsoltk opened this issue Jun 28, 2023 · 1 comment
Closed

Allow flag to control whether a gesture can be continuous #494

zsoltk opened this issue Jun 28, 2023 · 1 comment
Assignees
@KovalevAndrey @vladcipariu91
Labels
appyx-interactions complexity: low enhancement New feature or request gestures P1 priority: high
Milestone
2.0

Comments

@zsoltk
Copy link
Contributor

zsoltk commented Jun 28, 2023

Situation right now:

  • If a drag gesture can cover more than 1 length of an operation, the remainder is automatically interpreted as another model operation

Cases where this is desired:

  • Spotlight
  • Test drive
  • In general: models where a continuous dragging beyond one operation is what we want

Cases where this is not desired:

  • Back stack pop
  • Puzzle 15 move an element

In these cases the gesture should stop at the first operation's 100% completion boundary.

Idea:

Allow a flag inside Gesture to control this behaviour, and then the gesture factory (client code) can decide.
@zsoltk zsoltk added this to the 2.0 milestone Jun 28, 2023
@zsoltk zsoltk mentioned this issue Jun 28, 2023
Closed
@manuel-martos manuel-martos mentioned this issue Jun 30, 2023
Merged
2 tasks
@KovalevAndrey KovalevAndrey self-assigned this Jun 30, 2023
@vladcipariu91 vladcipariu91 mentioned this issue Sep 18, 2023
Merged
2 tasks
vladcipariu91 added a commit that referenced this issue Sep 19, 2023
@vladcipariu91
Merge pull request #599 from vladcipariu91/494_gesture_control_flag
8ccd6a3 
Issue #494: Add flag to control gesture continuity
@zsoltk
Copy link
Contributor Author

zsoltk commented Dec 4, 2023

Fixed in #599

@zsoltk zsoltk closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KovalevAndrey KovalevAndrey

@vladcipariu91 vladcipariu91

Labels
appyx-interactions complexity: low enhancement New feature or request gestures P1 priority: high
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@zsoltk @KovalevAndrey @vladcipariu91