Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing experimental configuration for extensions starting with API 0.13 #2125

Merged
merged 5 commits into from
May 3, 2024

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Apr 15, 2024

Summary

This PR adds some logic to determine when the experimental mode must be enable when running extensions. Since Platform API 0.13, extensions are no more experimental and pack doesn't need to set the env variable CNB_EXPERIMENTAL_MODE=warn, With this PR pack will evaluate if the API version is less than 0.13 and in such as case it will add the environment variable

Output

Before

Pack enables experimental mode when running against lifecycle < 0.18.x

After

When running with platform API <= 0.12

===> EXTENDING (BUILD)
Running the extender on OS linux from image pack.local/builder/6463666b7974676b7763:latest with:
Container Settings:
  Args: /cnb/lifecycle/extender -app /workspace -log-level debug
  System Envs: CNB_EXPERIMENTAL_MODE=warn CNB_PLATFORM_API=0.12

When running with platform API >= 0.13 the CNB_EXPERIMENTAL_MODE=warn env is not set

===> EXTENDING (BUILD)
Running the extender on OS linux from image pack.local/builder/6e647a67686d6278736d:latest with:
Container Settings:
  Args: /cnb/lifecycle/extender -app /workspace -log-level debug
  System Envs: CNB_PLATFORM_API=0.13

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #2066

@github-actions github-actions bot added this to the 0.34.0 milestone Apr 15, 2024
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (57282c7) to head (c53fbf5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
+ Coverage   69.60%   70.15%   +0.55%     
==========================================
  Files         231      231              
  Lines       17228    17227       -1     
==========================================
+ Hits        11990    12084      +94     
+ Misses       4457     4360      -97     
- Partials      781      783       +2     
Flag Coverage Δ
os_linux 69.30% <100.00%> (+0.02%) ⬆️
os_macos 65.72% <100.00%> (-<0.01%) ⬇️
os_windows 69.68% <100.00%> (+0.61%) ⬆️
unit 70.15% <100.00%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @jjbustamante

@jjbustamante jjbustamante marked this pull request as ready for review May 1, 2024 23:32
@jjbustamante jjbustamante requested review from a team as code owners May 1, 2024 23:32
@jjbustamante jjbustamante merged commit 32d8db5 into main May 3, 2024
18 checks passed
@jjbustamante jjbustamante deleted the enhancement/jjbustamante/issue-2066-part-1 branch May 3, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Platform API 0.13
2 participants