Platform 0.13: look for build Dockerfiles in <layers>/generated/<buildpack-id>/Dockerfile.build #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
…dpack-id>/Dockerfile.build Newer platforms don't copy the Dockerfile from where extensions output them Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
extensions-context
branch
from
78f3a7c to
869bc63
Compare
|
I was testing #2125 with the samples extensions and I realized I need this one first! :), when platform 0.13 is used I was getting: ERROR: open /var/folders/l7/zgqmtk951vx4dy6q8zl_9js80000gn/T/pack.tmp279107406/build: no such file or directoryI will merge than one after this. |
jjbustamante
reviewed
May 3, 2024
Signed-off-by: Natalie Arellano <[email protected]>
github-actions
bot
added
the
type/chore
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
- Coverage 70.29% 70.15% -0.14%
==========================================
Files 231 231
Lines 17104 17228 +124
==========================================
+ Hits 12022 12085 +63
- Misses 4317 4360 +43
- Partials 765 783 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
jjbustamante
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer platforms don't copy the Dockerfile from where extensions output them
Summary
Output
Before
After
Documentation
Related
Resolves #___