Commits on Nov 24, 2024

1. [CodeHealth] Migrate constants to use string_view …

   This PR changes a few places where we used to have we had something
   like:
   
   ```cxx
   constexpr const char* kConstant[] = ...
   ```
   
   These arrays array are not as safe as proper containers. There's also
   the challange that the strings referred by these arrays cannot have
   their sizes encoded on the type, so there's a certain reliance on
   `strlen` to determine the size.
   
   This change converts on of these arrays to `std::array`. The other array
   was converted to a `constexpr` flat set, as that is what this array was
   being used for. This flat set requires a custom comparator though, as
   the search of the elements as matching against `end_with`. With this
   change, the lookup will be a bit less wasteful.
   
   Resolves brave/brave-browser#42484

   

   cdesouza-chromium committed Nov 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9623be9
   • Browse repository at this point

   Copy the full SHA

   9623be9 View commit details

   Browse the repository at this point in the history