Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeHealth] Migrate constants to use string_view #26710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdesouza-chromium
Copy link
Collaborator

This PR changes a few places where we used to have we had something like:

constexpr const char* kConstant[] = ...

These arrays array are not as safe as proper containers. There's also the challange that the strings referred by these arrays cannot have their sizes encoded on the type, so there's a certain reliance on strlen to determine the size.

This change converts on of these arrays to std::array. The other array was converted to a constexpr flat set, as that is what this array was being used for. This flat set requires a custom comparator though, as the search of the elements as matching against end_with. With this change, the lookup will be a bit less wasteful.

Resolves brave/brave-browser#42484

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This PR changes a few places where we used to have we had something
like:

```cxx
constexpr const char* kConstant[] = ...
```

These arrays array are not as safe as proper containers. There's also
the challange that the strings referred by these arrays cannot have
their sizes encoded on the type, so there's a certain reliance on
`strlen` to determine the size.

This change converts on of these arrays to `std::array`. The other array
was converted to a `constexpr` flat set, as that is what this array was
being used for. This flat set requires a custom comparator though, as
the search of the elements as matching against `end_with`. With this
change, the lookup will be a bit less wasteful.

Resolves brave/brave-browser#42484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate kUnstoppableDomains and a few other string arrays to proper containers
1 participant