Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Remove video ambiance decoration in new Playlist UI #26704

Merged
merged 1 commit into from
Nov 23, 2024

Commits on Nov 22, 2024

  1. [iOS] Remove video ambiance decoration in new Playlist UI

    This feature was unfortunately causing multiple issues:
    
    - The very act of adding a new `AVPlayerItemVideoOutput` to `AVPlayerItem` caused audio-stutters when disconnecting the player layer from the player for background audio
    - It caused the `AVPlayerLayer` to break upon being restored back to the `AVPlayer` until paused + played
    - It caused high CPU usage which likely contributed to user reports of their phones getting hot while using the new playlist.
    
    For now this will be removed until we can find an alternative solution
    kylehickinson committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3af34d3 View commit details
    Browse the repository at this point in the history