Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Remove video ambiance decoration in new Playlist UI #26704

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Nov 22, 2024

This feature was unfortunately causing multiple issues:

  • The very act of adding a new AVPlayerItemVideoOutput to AVPlayerItem caused audio-stutters when disconnecting the player layer from the player for background audio
  • It caused the AVPlayerLayer to break upon being restored back to the AVPlayer until paused + played
  • It caused high CPU usage which likely contributed to user reports of their phones getting hot while using the new playlist.

For now this will be removed until we can find an alternative solution

Resolves brave/brave-browser#42468

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This feature was unfortunately causing multiple issues:

- The very act of adding a new `AVPlayerItemVideoOutput` to `AVPlayerItem` caused audio-stutters when disconnecting the player layer from the player for background audio
- It caused the `AVPlayerLayer` to break upon being restored back to the `AVPlayer` until paused + played
- It caused high CPU usage which likely contributed to user reports of their phones getting hot while using the new playlist.

For now this will be removed until we can find an alternative solution
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 22, 2024
@kylehickinson kylehickinson self-assigned this Nov 22, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner November 22, 2024 20:41
@kylehickinson kylehickinson merged commit 377101b into master Nov 23, 2024
18 checks passed
@kylehickinson kylehickinson deleted the ios-playlist-remove-ambiance-background branch November 23, 2024 01:52
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 23, 2024
brave-builds added a commit that referenced this pull request Nov 23, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.47

@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 25, 2024

Verified on iPhone 12 running iOS 18.0 using version 1.75 (48)

  • Confirmed that audio pauses/stutters when locking screen / backgrounding using 1.75 (44). Upgraded to 1.75 (48) and ensured that there is no audio disruptions when locking/unlocking and backgrounding.
  • Ensured that enabling Enable Background Audio does not change the how audio transitions when playing in background.
  • Ensured there are no audio issues using playlist controls as well as moving to and from PiP.

IMG_8068

kjozwiak pushed a commit that referenced this pull request Nov 25, 2024
kjozwiak pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Playlist audio stops and starts momentarily when locking/unlocking the device
5 participants