Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted location bar's icon radius, highlight path (uplift to 1.62.x) #21548

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Adjusted location bar's icon radius, highlight path (uplift to 1.62.x) #21548

merged 2 commits into from
Jan 15, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 11, 2024 •
edited by kjozwiak
Loading

Uplift of #21464
Uplift of #21535
Resolves brave/brave-browser#34957
Resolves brave/brave-browser#35191

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 11, 2024 03:36
@brave-builds brave-builds requested a review from a team January 11, 2024 03:36
@brave-builds brave-builds added this to the 1.62.x - Beta milestone Jan 11, 2024
@brave-builds brave-builds self-assigned this Jan 11, 2024
kjozwiak
kjozwiak approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the PR on Nightly via 1.63.x as per brave/brave-browser#34957 (comment) & brave/brave-browser#35191 (comment).

@kjozwiak kjozwiak merged commit 1d93953 into 1.62.x Jan 15, 2024
13 checks passed
@kjozwiak kjozwiak deleted the pr21464_adjust_location_bar_icon_layout_1.62.x branch January 15, 2024 23:24
This was referenced Jan 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @simonhong