Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site-permissions bubbles are still circular, rather than squares/square-ish #35191

Closed
stephendonner opened this issue Jan 9, 2024 · 3 comments · Fixed by brave/brave-core#21535

Comments

@stephendonner
Copy link

Description

Site-permissions bubbles are still circular, rather than squares/square-ish

Found while testing #34957

Steps to Reproduce

  1. install 1.63.102
  2. launch Brave
  3. load permission.site
  4. click on Camera (or most categories)
  5. note the circle-shaped permission bubble
  6. click Allow
  7. note the circle-shaped permission bubble

Actual result:

Use Camera? Allowed
Screenshot 2024-01-08 at 5 13 24 PM Screenshot 2024-01-08 at 5 13 27 PM

Expected result:

Should be more square/square-ish

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.63.102 Chromium: 120.0.6099.199 (Official Build) nightly (x86_64)
-- | --
Revision | e04c47f4648bb8a13cad74d386e61d33a80d70be
OS | macOS Version 14.3 (Build 23D5043d)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @simonhong @aguscruiz @brave/qa-team

@stephendonner
Copy link
Author

Verified PASSED using

Brave | 1.63.108 Chromium: 120.0.6099.217 (Official Build) nightly (x86_64)
-- | --
Revision | af39b0a02af610eb272f84079ef80aecc3809261
OS | macOS Version 11.7.10 (Build 20G1427)

Light

example example
Screen Shot 2024-01-10 at 1 14 40 PM Screen Shot 2024-01-10 at 1 14 45 PM

Dark

example example
Screen Shot 2024-01-10 at 1 19 36 PM Screen Shot 2024-01-10 at 1 19 47 PM

@kjozwiak
Copy link
Member

Removing QA Pass-macOS as the above will need to be verified via 1.62.x now that it's been uplifted via brave/brave-core#21548. However, used #35191 (comment) as the needed verification for uplifting as per brave/brave-core#21548 (review).

The above requires 1.62.144 or higher for 1.62.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 16, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Jan 16, 2024

Verified with

Brave | 1.62.144 Chromium: 120.0.6099.217 (Official Build) beta (x86_64)
-- | --
Revision | 75de8d953f6a5686e425d46d7f0dc9284dc1c064
OS | macOS Version 13.6.3 (Build 22G436)

Encountered #35358 while testing.

Tested as part of #34957 (comment).

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment