Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SKU SDK on Linux by default #13702

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jun 8, 2022

Disable SKU SDK on Linux by default. VPN is not available for Linux yet - so it's safe to turn off.

This fixes the crash that we're seeing. I'll open a specific issue for that problem; we still need to troubleshoot why an invalid instruction is executed on Linux when this is enabled.

Resolves brave/brave-browser#23140

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used GitHub auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Have an official build with this code
  2. Be on Linux
  3. Login to account.brave.com
  4. It should work and not crash

@bsclifton bsclifton requested review from bridiver and simonhong June 8, 2022 23:12
@bsclifton bsclifton self-assigned this Jun 8, 2022
@bsclifton bsclifton force-pushed the bsc-linux-premium-crash-fix branch from e6b3f94 to 37920d2 Compare June 8, 2022 23:20
@bsclifton bsclifton added this to the 1.41.x - Nightly milestone Jun 9, 2022
@bsclifton bsclifton merged commit d3fb1d2 into master Jun 9, 2022
@bsclifton bsclifton deleted the bsc-linux-premium-crash-fix branch June 9, 2022 05:51
brave-builds pushed a commit that referenced this pull request Jun 9, 2022
brave-builds pushed a commit that referenced this pull request Jun 9, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Pop OS 22.04 x64 using the following build(s):

Brave | 1.41.61 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit) 
--- | ---
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | Linux

I couldn't reproduce the original issue using either 1.41.12 or 1.41.49 but verified that the above is still working with the latest Nightly using the STR/Cases outlined via brave/brave-browser#23140 (comment) & #13702 (comment). @wknapik also verified the the issue was fixed on Nightly as per brave/brave-browser#23140 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser crash when logging into Brave Premium account on Linux
4 participants