Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement buy options new design (uplift to 1.40.x) #13731

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Implement buy options new design (uplift to 1.40.x) #13731

merged 1 commit into from
Jun 14, 2022

Conversation

muliswilliam
Copy link
Contributor

@muliswilliam muliswilliam commented Jun 10, 2022 •
edited by kjozwiak
Loading

Uplift of #13708
Resolves brave/brave-browser#23349

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@muliswilliam muliswilliam requested a review from a team as a code owner June 10, 2022 10:04
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jun 10, 2022
@muliswilliam muliswilliam requested a review from a team June 10, 2022 10:05
@muliswilliam muliswilliam added this to the 1.40.x - Beta milestone Jun 10, 2022
@muliswilliam muliswilliam force-pushed the pr13708_buy-tab-v2-user-flow_1.40.x branch from 6e5d967 to 2aa2c43 Compare June 10, 2022 12:09
@muliswilliam
Implement buy options new design (#13708)
8525cec 
* Implement buy options new design

* Feedback fixes
@muliswilliam muliswilliam force-pushed the pr13708_buy-tab-v2-user-flow_1.40.x branch from 2aa2c43 to 8525cec Compare June 10, 2022 12:12
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak mentioned this pull request Jun 14, 2022
Closed
kjozwiak
kjozwiak approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.40.x approved 👍 QA has verified the PR on Nightly as per #13708 (comment).

@kjozwiak kjozwiak merged commit b6ac7f0 into 1.40.x Jun 14, 2022
@kjozwiak kjozwiak deleted the pr13708_buy-tab-v2-user-flow_1.40.x branch June 14, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.40.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@muliswilliam @brave-builds @kjozwiak