Remove entry point for cellfinder workflow #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 79.43% 79.38% -0.05%
==========================================
Files 18 18
Lines 924 917 -7
==========================================
- Hits 734 728 -6
+ Misses 190 189 -1 ☔ View full report in Codecov by Sentry. |
|
Could you update the PR description somehow (even just a short sentence linking to a larger issue, which is only partially addressed by this PR) so our future selves remember why we did this, please? |
|
yes sorry, I completely missed it! |
alessandrofelder
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
We expect that the main way the workflows will be useful for users is as reference scripts that they can "copy-paste" and adapt to their workflows. Therefore for simplicity we agreed to remove the entry point for the cellfinder workflow script.
Related to #9
What does this PR do?
Removes the entry point to the cellfinder workflow script
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
We had smoke tests for the entry point before but these are removed in this PR.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: