Prepare for cellfinder merge
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
willGraham01
force-pushed
the
prepare-for-cellfinder-update
branch
2 times, most recently
from
d27d9c1 to
df16e45
Compare
With the removal of tox.ini from main branch, also remove the now-redundant check on the development version of cellfinder
willGraham01
force-pushed
the
prepare-for-cellfinder-update
branch
from
df16e45 to
4a2c551
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 32 32
Lines 1586 1586
=======================================
Hits 1290 1290
Misses 296 296 ☔ View full report in Codecov by Sentry. |
adamltyson
approved these changes
Jan 3, 2024
Co-authored-by: Adam Tyson <[email protected]>
|
Fab, will merge when https://github.com/brainglobe/brainglobe-workflows/actions/runs/7396094521 completes. (This is running on 036b083, which is the last edit to the actual code, and I don't fancy waiting another 4 hours for the tests to pass again). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See brainglobe/BrainGlobe#46
Prepares the package for the update to
cellfindercellfinder_core->cellfinder.coreeverywherecellfinder, if requestedcellfinder>=1.0.0.naparioptional dependency is still available.cellfinderis now calledbrainmapper.On merge, create new released on PyPI