feat: Add dynamic lists component #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
bpmn-io-tasks
bot
added
in progress
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
Skaiir
force-pushed
the
repeated-subforms-prototype
branch
from
df8c23a to
8a09bfe
Compare
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
Skaiir
force-pushed
the
repeated-subforms-prototype
branch
from
845453c to
315fe96
Compare
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
Skaiir
force-pushed
the
repeated-subforms-prototype
branch
from
315fe96 to
f46e73f
Compare
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
Skaiir
force-pushed
the
repeated-subforms-prototype
branch
from
1723abf to
ac38537
Compare
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
Skaiir
force-pushed
the
repeated-subforms-prototype
branch
from
ac38537 to
c523b26
Compare
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
Skaiir
force-pushed
the
repeated-subforms-prototype
branch
from
2574a40 to
719e560
Compare
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
Skaiir
force-pushed
the
repeated-subforms-prototype
branch
from
719e560 to
842762c
Compare
|
Bug 1 resolved, bug 2 is historical and is tracked at #943 |
|
Some other small problems I found:
|
Skaiir
added a commit
that referenced
this pull request
Dec 12, 2023
Skaiir
added a commit
that referenced
this pull request
Dec 12, 2023
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
vsgoulart
force-pushed
the
repeated-subforms-prototype
branch
from
fc490a9 to
c3c8802
Compare
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
vsgoulart
force-pushed
the
repeated-subforms-prototype
branch
from
c3c8802 to
4583328
Compare
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
…-io/form-js into repeated-subforms-prototype
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
Related to #808
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
vsgoulart
approved these changes
Dec 13, 2023
github-actions
bot
temporarily deployed
to
demo-repeated-subforms-prototy
vsgoulart
added a commit
that referenced
this pull request
Dec 13, 2023
* chore: rename expression-language folder * wip: implemented protoype repeatRenderManager * feat: `subform` component * feat: integrated prototype repeatRenderModule * feat: hooked up indexing to update cycle Related to #796 * feat: subform properties panel configuration Related to #796 * feat: added group styles to subform * feat: form initializer works with repeatable Related to #796 * chore: display key and path from config Related to #796 * feat: enforce path for repeatable groups Related to #796 * feat: adjusted getSubmitData for repeatable Related to #796 * feat: repeat render manager Closes #796 * chore: renamed subform to dynamic list Related to #796 * chore: adjusted path tooltip for repeating Related to #796 * feat: repeated element validation Related to #796 * wip: custom editor list renderer (missing icon) Related to #796 * wip: collapse / expand dynamic lists Related to #796 * feat: implement group/list alignment Related to #796 * chore: added empty states to group and list Related to #796 * feat: brought in new icons and matched visuals Related to #796 * fix: form root outline never shows * fix: editor no longer refreshes on element hover Closes #807 Related to #796 * feat: add/remove items in dynamic lists Related to #796 * feat: local expression contexts Related to #796 * feat: add/remove styles Related to #796 * feat: automatically scroll when adding item Related to #796 * feat: refine add/remove UX Related to #796 * chore: use karma-spec reporter for tests * chore: refactored viewer and editor tests Related to #808 * chore: large rebase test cleanups Related to #808 * fix(submit): only modify error object when needed Related to #808 * fix: final repeated subforms test adjustments Related to #808 * chore: fixed minor tabs and naming issues Related to #808 * feat: added carbon styles for dynamic list Related to #907 * fix: improved dynamic list button outlines Related to #808 * chore: rebase changes on `develop` * chore: reduced nesting and improved docs in Form.js core functions Related to #808 * chore: removed pointless useMemo Related to #808 * chore: cleanup remnants of ai generation Related to #808 * chore: switch from hardcoded to computed componentCount test Related to #808 * fix(performance): centralize variable filtering Related to camunda/tasklist#3758 * chore: optimize svgs Related to #808 * feat: implemented proper path management for repeatable fields Related to #808 * fix: always expand when uncollapsible Related to #808 * fix: proper key change handling and repeatable filtering Related to #808 * feat: implement proper variable hiding within repeated field Related to #808 * chore: adjust table/iframe tests following rebase Related to #808 * fix: adjust numerical configs of dynamic list to prevent crashes Related to #808 * fix: properly split path replacements in pathEntry Related to #808 * fix: ensure dynamic list buttons don't submit Related to #808 * feat: Carbonise dynamic list * fix: show proper default uncollapsed items in propspan Related to #808 * feat(schema): added dynamic list component Related to #808 * chore(schema): adjust test indexes Related to #808 --------- Co-authored-by: Niklas Kiefer <[email protected]> Co-authored-by: Vinicius Goulart <[email protected]>
vsgoulart
added a commit
that referenced
this pull request
Dec 14, 2023
* chore: update dependency lerna to v8 (#914) * chore: update dependency lerna to v8 * deps: remove legacy lerna scripts Cf. https://lerna.js.org/docs/legacy-package-management --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Niklas Kiefer <[email protected]> Co-authored-by: Vinícius Goulart <[email protected]> * chore(CI): updated snapshots [skip ci] * deps: update dependency didi to v10 (#909) * deps: update dependency didi to v10 * chore: Bump to [email protected] --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vinicius Goulart <[email protected]> * chore(CI): updated snapshots [skip ci] * chore: Bump to [email protected] (#927) * deps: update dependency feelin to v3 (#941) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: Bump `schemaVersion` to 13 (#896) * chore: Bump schemaVersion to 13 * chore: Fix formatting Co-authored-by: Niklas Kiefer <[email protected]> * fix: Fix schema version range on docs * chore: Remove newline * feat: Make columns and columnsExpression mutually exclusive * feat: Add custom error message --------- Co-authored-by: Niklas Kiefer <[email protected]> * chore: Fix typos in comments * feat: Add table component to editor (#905) * feat: Add table component to editor * chore: Replace key with id * chore: Fix typo * feat: Add dataSource to schema * fix: Rework initialDemoData and add test * chore: Update formatting Co-authored-by: Niklas Kiefer <[email protected]> --------- Co-authored-by: Niklas Kiefer <[email protected]> * feat: Add table entries to properties panel (#912) * chore: Bump `schemaVersion` to 13 (#896) * chore: Bump schemaVersion to 13 * chore: Fix formatting Co-authored-by: Niklas Kiefer <[email protected]> * fix: Fix schema version range on docs * chore: Remove newline * feat: Make columns and columnsExpression mutually exclusive * feat: Add custom error message --------- Co-authored-by: Niklas Kiefer <[email protected]> * feat: Add table component to editor (#905) * feat: Add table component to editor * chore: Replace key with id * chore: Fix typo * feat: Add dataSource to schema * fix: Rework initialDemoData and add test * chore: Update formatting Co-authored-by: Niklas Kiefer <[email protected]> --------- Co-authored-by: Niklas Kiefer <[email protected]> * chore: Remove commented code * feat: Add table entries to properties panel * fix: Fix tooltip Co-authored-by: Niklas Kiefer <[email protected]> * chore: Rename id * feat: Use behavior to manage column headers * chore: Fix test description Co-authored-by: Niklas Kiefer <[email protected]> --------- Co-authored-by: Niklas Kiefer <[email protected]> * feat: Add table component to viewer (#920) * feat: Add table component to viewer * fix: Fix default rowCount * feat: Add generic data on editor view * fix: Refactor form field table styles * test: Add tests * fix: Turn data source into FEEL only * chore: Remove unnecessary new line * chore: Remove FEEL check on dataSource * chore: Sort by asc first * chore: Remove unnecessary label check * chore: Use const instead of let * fix: Create EditorTable * chore: Fix formatting * chore: Make label id optional * fix: Add row gap * fix: Add missing leftovers from table component (#938) * feat: Add Carbon compatibility styles (#937) * feat: Add Carbon compatibility styles * test: Add Carbon tests * feat: Add dynamic lists component (#808) * chore: rename expression-language folder * wip: implemented protoype repeatRenderManager * feat: `subform` component * feat: integrated prototype repeatRenderModule * feat: hooked up indexing to update cycle Related to #796 * feat: subform properties panel configuration Related to #796 * feat: added group styles to subform * feat: form initializer works with repeatable Related to #796 * chore: display key and path from config Related to #796 * feat: enforce path for repeatable groups Related to #796 * feat: adjusted getSubmitData for repeatable Related to #796 * feat: repeat render manager Closes #796 * chore: renamed subform to dynamic list Related to #796 * chore: adjusted path tooltip for repeating Related to #796 * feat: repeated element validation Related to #796 * wip: custom editor list renderer (missing icon) Related to #796 * wip: collapse / expand dynamic lists Related to #796 * feat: implement group/list alignment Related to #796 * chore: added empty states to group and list Related to #796 * feat: brought in new icons and matched visuals Related to #796 * fix: form root outline never shows * fix: editor no longer refreshes on element hover Closes #807 Related to #796 * feat: add/remove items in dynamic lists Related to #796 * feat: local expression contexts Related to #796 * feat: add/remove styles Related to #796 * feat: automatically scroll when adding item Related to #796 * feat: refine add/remove UX Related to #796 * chore: use karma-spec reporter for tests * chore: refactored viewer and editor tests Related to #808 * chore: large rebase test cleanups Related to #808 * fix(submit): only modify error object when needed Related to #808 * fix: final repeated subforms test adjustments Related to #808 * chore: fixed minor tabs and naming issues Related to #808 * feat: added carbon styles for dynamic list Related to #907 * fix: improved dynamic list button outlines Related to #808 * chore: rebase changes on `develop` * chore: reduced nesting and improved docs in Form.js core functions Related to #808 * chore: removed pointless useMemo Related to #808 * chore: cleanup remnants of ai generation Related to #808 * chore: switch from hardcoded to computed componentCount test Related to #808 * fix(performance): centralize variable filtering Related to https://github.com/camunda/tasklist/issues/3758 * chore: optimize svgs Related to #808 * feat: implemented proper path management for repeatable fields Related to #808 * fix: always expand when uncollapsible Related to #808 * fix: proper key change handling and repeatable filtering Related to #808 * feat: implement proper variable hiding within repeated field Related to #808 * chore: adjust table/iframe tests following rebase Related to #808 * fix: adjust numerical configs of dynamic list to prevent crashes Related to #808 * fix: properly split path replacements in pathEntry Related to #808 * fix: ensure dynamic list buttons don't submit Related to #808 * feat: Carbonise dynamic list * fix: show proper default uncollapsed items in propspan Related to #808 * feat(schema): added dynamic list component Related to #808 * chore(schema): adjust test indexes Related to #808 --------- Co-authored-by: Niklas Kiefer <[email protected]> Co-authored-by: Vinicius Goulart <[email protected]> * chore: update actions/setup-node digest to 7247617 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Niklas Kiefer <[email protected]> Co-authored-by: Vinícius Goulart <[email protected]> Co-authored-by: bpmn-io-bot <[email protected]> Co-authored-by: Valentin Serra <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #796