Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle self conflicting empty group pathes #943

Open
Skaiir opened this issue Dec 12, 2023 · 0 comments
Open

Handle self conflicting empty group pathes #943

Skaiir opened this issue Dec 12, 2023 · 0 comments
Labels
backlog Queued in backlog bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Dec 12, 2023

Describe the Bug

#808 (review)

An empty path in a group can conflict when setting its value to that of the path of its direct child. This isn't majorly problematic because the workaround is simple, see linked issue for a more visual example.

Steps to Reproduce

  1. Add a group
  2. Add a checkbox inside that group
  3. Set the checkbox's key to test
  4. Set the group's key to test
  5. A conflict is triggered, disallowing the configuration
  6. Set the group's key to test1
  7. Set the group's key back to test
  8. Works as e

Expected Behavior

  1. No conflict should be triggered, path validation shouldn't consider direct children for groups.

This can most likely be fixed the same way as keys by temporarily de-registering all the paths associated with the group before doing the check (search // unclaim temporarily to avoid self-conflicts)

@Skaiir Skaiir added the bug Something isn't working label Dec 12, 2023
@nikku nikku added the backlog Queued in backlog label Dec 18, 2023 — with bpmn-io-tasks
@marcosgvieira marcosgvieira added the spring cleaning Could be cleaned up one day label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

3 participants