chore: update dependency bpmn-js to v18 #196
Merged
Commits on Nov 7, 2024
-
-
-
-
-
-
-
-
-
-
fix(animation): clear animation when destroying diagram
Previously animations would continue _after_ the diagram got destroyed, with all the funny effects related to it. Specifically, this starts to trigger test errors in our setup.
-
fix(animation): don't trigger <done> when clearing animation
Previously we did not properly separate completion from clearing an animation; we would not properly be able to distinguish both, effectively always triggering the animation <done> effect, also when clearing a scope (i.e. because it was terminated). This change moves the control over individual animations to the animation service, and applies <done> only when the animation completes normally.
-
-
-
As of today it cannot reliably be executed as part of the test suite; works fine at any speed when run focused.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.