-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependency bpmn-js to v18 #196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
force-pushed
the
renovate/bpmn-js-18.x
branch
from
November 7, 2024 08:39
fe67410
to
dd9c9a7
Compare
Example works well with the new implicit keyboard. To be merged with additional housekeeping. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
nikku
added
in progress
Currently worked on
and removed
needs review
Review pending
labels
Nov 7, 2024
Test case failures need further investigation. |
Previously animations would continue _after_ the diagram got destroyed, with all the funny effects related to it. Specifically, this starts to trigger test errors in our setup.
Previously we did not properly separate completion from clearing an animation; we would not properly be able to distinguish both, effectively always triggering the animation <done> effect, also when clearing a scope (i.e. because it was terminated). This change moves the control over individual animations to the animation service, and applies <done> only when the animation completes normally.
As of today it cannot reliably be executed as part of the test suite; works fine at any speed when run focused.
nikku
force-pushed
the
renovate/bpmn-js-18.x
branch
from
November 7, 2024 14:38
6529f11
to
0cb5034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^17.9.2
->^18.0.0
Release Notes
bpmn-io/bpmn-js (bpmn-js)
v18.0.0
Compare Source
FEAT
: removeoutline
fromViewer
modules (#2135)FEAT
: makeCanvas
a focusable element (bpmn-io/diagram-js#662)FEAT
: implicit keyboard binding (bpmn-io/diagram-js#662)FEAT
: integrate with globalsearch
(#2235)FIX
: prevent crash during label adjustment (#2239)FIX
: keep existing loop characteristics when toggling through the replace menu (#2251)FIX
: prevent covering multi selection with black box inViewer
(#2135)FIX
: generate types for main entry (986e2bb
)FIX
: correct handling of group name with whitespace only (#2231)DEPS
: update tobpmn-moddle@9
(#2114)DEPS
: update to[email protected]
DEPS
: update to[email protected]
Breaking Changes
Node >= 20
Canvas
is now a focusable element and provides better support for native browser behaviors. Focus can be controlled with newfocus
andrestoreFocus
APIs.keyboard.bind
andkeyboard.bindTo
now result with a descriptive console error and have no effect.v17.11.1
Compare Source
FIX
: handle searching elements without labels (#2232, #2234)v17.11.0
Compare Source
FEAT
: align search styles with other popups (#2187)FEAT
: prioritize start of tokens in search results (#2187)FIX
: do not commit viewport changes onESC
(#2189, #2187)DEPS
: update to[email protected]
v17.10.0
Compare Source
CHORE
: correct various type hints (#2228)FIX
: pasting compensation activity without boundary event (#2070)FIX
: lane resize constraints for se and nw direction (#2209)FIX
: auto place elements vertically in sub-processes (#2127)FIX
: hide lane label during direct editingDEPS
: update to[email protected]
Configuration
📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.