Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency bpmn-js to v18 #196

Merged
merged 15 commits into from
Nov 7, 2024
Merged

chore: update dependency bpmn-js to v18 #196

merged 15 commits into from
Nov 7, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 7, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
bpmn-js ^17.9.2 -> ^18.0.0 age adoption passing confidence

Release Notes

bpmn-io/bpmn-js (bpmn-js)

v18.0.0

Compare Source

Breaking Changes
  • Require Node >= 20
  • Canvas is now a focusable element and provides better support for native browser behaviors. Focus can be controlled with new focus and restoreFocus APIs.
  • Keyboard is now implicitly bound to canvas SVG element. Calls to keyboard.bind and keyboard.bindTo now result with a descriptive console error and have no effect.

v17.11.1

Compare Source

v17.11.0

Compare Source

v17.10.0

Compare Source

  • CHORE: correct various type hints (#​2228)
  • FIX: pasting compensation activity without boundary event (#​2070)
  • FIX: lane resize constraints for se and nw direction (#​2209)
  • FIX: auto place elements vertically in sub-processes (#​2127)
  • FIX: hide lane label during direct editing
  • DEPS: update to [email protected]

Configuration

📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Updates a dependency label Nov 7, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 7, 2024
@nikku nikku self-assigned this Nov 7, 2024
@nikku
Copy link
Member

nikku commented Nov 7, 2024

Example works well with the new implicit keyboard. To be merged with additional housekeeping.

Copy link
Contributor Author

renovate bot commented Nov 7, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@nikku nikku added in progress Currently worked on and removed needs review Review pending labels Nov 7, 2024
@nikku
Copy link
Member

nikku commented Nov 7, 2024

Test case failures need further investigation.

Previously animations would continue _after_ the diagram got destroyed,
with all the funny effects related to it.

Specifically, this starts to trigger test errors in our setup.
Previously we did not properly separate completion from clearing an
animation; we would not properly be able to distinguish both,
effectively always triggering the animation <done> effect, also when
clearing a scope (i.e. because it was terminated).

This change moves the control over individual animations to the
animation service, and applies <done> only when the animation completes
normally.
As of today it cannot reliably be executed as part of the
test suite; works fine at any speed when run focused.
@nikku
Copy link
Member

nikku commented Nov 7, 2024

Ok, so test failures were unrelated to the update, but an actual bug in animation, cf. 9693207 and 04cea80.

@nikku nikku merged commit 1545d79 into main Nov 7, 2024
6 checks passed
@nikku nikku deleted the renovate/bpmn-js-18.x branch November 7, 2024 14:40
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant