Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc: document crontab trigger #59
cc: document crontab trigger #59
Changes from 8 commits
9638b0a
26c7b1e
10bcb83
de77f64
dc74192
9613e5f
23da7ce
b5c8885
38697f9
0c43075
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved to the rest of the image caption at the start of this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure I understand what you’re asking for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SoggySaussages I cannot see any change addressing this comment--did you perhaps forget to push your changes or publish your response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, maybe you can’t see my response. I replied to this saying “I’m not sure I understand what you’re asking for,” which still stands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have this section (after the callout and until the next heading) moved further up, before the table explaining how a cron expression is structured.
As it stands, we have a screenshot of the page, with its appropriate caption, then go to great lengths of explaining a single marked thing in that screenshot (the cron expression labelled 1), then have more references to the image. This makes this section awkward to read--a reader would have to scroll back up for the visual reference the image is supposed to provide.
Though these additional fields are quickly explained, I'd rather have them at the top with the description of the cron expression, and only after the image is fully describe we explain how to construct a cron expression. That way, we have the image closer to the text that is describing it, eliminating or reducing the need to scroll back up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's done.