cc: document crontab trigger #59
Conversation
There was a problem hiding this comment.
As a general comment, I think we should link to https://crontab.guru/ or a similar tool somewhere in this documentation.
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
I’m not seeing what’s missing from your last review apart from a general comment, what are the unresolved suggestions from your last review? |
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
There was a problem hiding this comment.
Sorry for the confusion, I just meant the reference to crontab.guru and the (not fully realized) suggestion to copy the documentation from robfig/cron. This LGTM now, but I will wait for @l-zeuch for any final thoughts and merge.
| Channel (**2**) specifies a channel to run the command in. The response, if any, will be sent to this channel. | ||
|
|
||
| Excluding hours and/or weekdays (**3**) prevents the command from triggering during those hours or weekdays. **This uses | ||
| UTC time**, not your local timezone. | ||
|
|
||
| You must specify a channel to run time-based commands in even if the command doesn't output a message. |
There was a problem hiding this comment.
This should be moved to the rest of the image caption at the start of this section.
There was a problem hiding this comment.
I’m not sure I understand what you’re asking for.
There was a problem hiding this comment.
@SoggySaussages I cannot see any change addressing this comment--did you perhaps forget to push your changes or publish your response?
There was a problem hiding this comment.
Oh sorry, maybe you can’t see my response. I replied to this saying “I’m not sure I understand what you’re asking for,” which still stands.
There was a problem hiding this comment.
I'd like to have this section (after the callout and until the next heading) moved further up, before the table explaining how a cron expression is structured.
As it stands, we have a screenshot of the page, with its appropriate caption, then go to great lengths of explaining a single marked thing in that screenshot (the cron expression labelled 1), then have more references to the image. This makes this section awkward to read--a reader would have to scroll back up for the visual reference the image is supposed to provide.
Though these additional fields are quickly explained, I'd rather have them at the top with the description of the cron expression, and only after the image is fully describe we explain how to construct a cron expression. That way, we have the image closer to the text that is describing it, eliminating or reducing the need to scroll back up.
Signed-off-by: SoggySaussages <[email protected]>
|
Sorry I’m just realizing a bunch of comments were left pending in s review instead of posted as individual comments, my apologies. I’m not sure how I did that. Most of these comments I just published are a few days old. |
Signed-off-by: SoggySaussages <[email protected]>
Documents the new crontab trigger, linking robfig's docs, Wikipedia, and outlining some examples of common schedules.
Terms
Signed-off-by: SoggySaussages [email protected]