-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Dashboard api endpoint 작성 #129
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9f6fd91
feat: dashboard api endpoint 작성
Jieun1ee 8db4325
fix: Merge develop into feat/#128/create-dashboard-api-endpoint
Jieun1ee 0b7b881
feat: participants 대신 applicants로 변경
Jieun1ee cc82282
Merge branch 'develop' into feat/#128/create-dashboard-api-endpoint
Jieun1ee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { Controller, Get, Param, Post } from '@nestjs/common'; | ||
|
||
@Controller('dashboard') | ||
export class DashboardController { | ||
constructor() {} | ||
|
||
@Get('created') | ||
getCreatedTicleList() {} | ||
|
||
@Get('applied') | ||
getAppliedTicleList() {} | ||
|
||
@Get('created/:ticleId/participants') | ||
getParticipants(@Param('ticleId') ticleId: number) {} | ||
|
||
@Post('created/:ticleId/start') | ||
startTicle(@Param('ticleId') ticleId: number) {} | ||
|
||
@Post('applied/:ticleId/join') | ||
joinTicle(@Param('ticleId') ticleId: number) {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import { Module } from '@nestjs/common'; | ||
|
||
@Module({}) | ||
export class DashboardModule {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3
다른 곳에서는 'apply'라는 단어를 사용하고있는 것을 고려했을 때
여기서도 participants가 아닌 applicants를 사용하는 건 어떨까요?
실제로 참여자라기보단 신청자의 의미가 들어가야하니 의미상으로도 더 적절해보여서요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞아요 제가 그냥 참여자라고 생각해서 그렇게 썼는데 db 테이블도 applicant로 되어있어서 그게 맞는 것 같습니다 ㅎㅎ 바로 수정완료했어요~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm install로 바로 해결 완료 했습니다 ㅎㅎ 갑작스런 에러여서 놀랐네여.. 감사합니다 !