[Feat] Dashboard api endpoint 작성 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jieun1ee
requested review from
seoko97,
begong313,
simeunseo and
Fixtar
as code owners
simeunseo
reviewed
Nov 10, 2024
Comment on lines
13
to
14
| @Get('created/:ticleId/participants') | ||
| getParticipants(@Param('ticleId') ticleId: number) {} |
There was a problem hiding this comment.
P3
다른 곳에서는 'apply'라는 단어를 사용하고있는 것을 고려했을 때
여기서도 participants가 아닌 applicants를 사용하는 건 어떨까요?
실제로 참여자라기보단 신청자의 의미가 들어가야하니 의미상으로도 더 적절해보여서요!
There was a problem hiding this comment.
맞아요 제가 그냥 참여자라고 생각해서 그렇게 썼는데 db 테이블도 applicant로 되어있어서 그게 맞는 것 같습니다 ㅎㅎ 바로 수정완료했어요~!
There was a problem hiding this comment.
pnpm install로 바로 해결 완료 했습니다 ㅎㅎ 갑작스런 에러여서 놀랐네여.. 감사합니다 !
simeunseo
approved these changes
Nov 10, 2024
seoko97
approved these changes
Nov 10, 2024
Fixtar
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
작업 내용
PR 포인트
고민과 학습내용
스크린샷