장소에 색상 추가 #100
Merged
장소에 색상 추가 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miensoap
requested review from
koomchang,
1119wj and
hyohyo12
as code owners
Miensoap
force-pushed
the
feature/#86
branch
from
f415ec8 to
30ee690
Compare
koomchang
requested changes
Nov 11, 2024
Comment on lines
+13
to
+15
| new UnknownExceptionFilter(), | ||
| new HttpExceptionFilter(), | ||
| new BaseExceptionFilter(), |
There was a problem hiding this comment.
q: BaseException이 HttpException을 상속받기 때문에 실행 순서가 중요할 것 같은데요. Filter가 순서가 적용되는지 확인을 해야할 것 같습니다. 순서가 적용된다면 순서도 바꿔야 겠네요.
제가 테스트 했을 때는 효과가 없었던 것 같아서 GlobalExceptionFilter에서 if 로 구분했었거든요. 한번 확인해보고 알려주세요!
There was a problem hiding this comment.
이거 PR 메시지에 적었는데요,
당연히 좁은 범위를 먼저 선언해야 할 것 같지만
반대로 넓은 범위를 먼저 선언해야 제대로 작동하더라구요
There was a problem hiding this comment.
이거 PR 메시지에 적었는데요,
당연히 좁은 범위를 먼저 선언해야 할 것 같지만 반대로 넓은 범위를 먼저 선언해야 제대로 작동하더라구요
헉 충격적이군요 좋습니다
Miensoap
force-pushed
the
feature/#86
branch
from
04084ad to
1020a66
Compare
koomchang
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More
🕰️ Actual Time of Completion
close #86