refactor: 코스/지도에 장소 추가 전 확인 메서드명 수정 #86

boostcampwm-2024 · Nov 11, 2024 · 04084ad · 04084ad
1 parent 13f50e2
commit 04084ad
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/backend/src/course/course.service.ts b/backend/src/course/course.service.ts
@@ -118,7 +118,7 @@ export class CourseService {
     const course = await this.courseRepository.findById(id);
     if (!course) throw new CourseNotFoundException(id);
 
-    await this.checkPlacesExist(
+    await this.validatePlacesForCourse(
       setPlacesOfCourseRequest.places.map((p) => p.placeId),
     );
 
@@ -131,7 +131,7 @@ export class CourseService {
     };
   }
 
-  private async checkPlacesExist(placeIds: number[]) {
+  private async validatePlacesForCourse(placeIds: number[]) {
     const notExistsPlaceIds = await Promise.all(
       placeIds.map(async (placeId) => {
         const exists = await this.placeRepository.existById(placeId);

diff --git a/backend/src/map/map.service.ts b/backend/src/map/map.service.ts
@@ -112,7 +112,7 @@ export class MapService {
   ) {
     const map = await this.mapRepository.findById(id);
     if (!map) throw new MapNotFoundException(id);
-    await this.checkPlaceCanAddToMap(placeId, map);
+    await this.validatePlacesForMap(placeId, map);
 
     map.addPlace(placeId, color, comment);
     await this.mapRepository.save(map);
@@ -124,7 +124,7 @@ export class MapService {
     };
   }
 
-  private async checkPlaceCanAddToMap(placeId: number, map: Map) {
+  private async validatePlacesForMap(placeId: number, map: Map) {
     if (!(await this.placeRepository.existById(placeId))) {
       throw new InvalidPlaceToMapException(placeId);
     }