New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: comment on make transactions and add transaction mined period #201

Merged

0xneves merged 3 commits into blockful-io:develop from 0xneves:better-scripts

Mar 15, 2024

Contributor

0xneves commented Mar 15, 2024 •

edited

Loading

Doc Refactor

Changing the comment description of make transaction script on Makefile.
Adding wait tx.wait() to wait transactions to be mined to not mess up the script sequence when saving on .env and risking script continuation without the right parameters.

0xneves added 3 commits

March 14, 2024 21:49


          feat: waiting for transaction to be mined

5037a4f


          fix: wrong comment on make transactions

9ca5308


          fix: default should be set to localhost

8ef44f4

0xneves added the bug label

0xneves self-assigned this

0xneves added documentation and removed bug labels

0xneves changed the title ~~fix: wrong comment on make transactions~~ fix: comment on make transactions and add transaction mined period

0xneves merged commit 257d907 into blockful-io:develop

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels