Merge pull request #201 from 0xneves/better-scripts

fix: comment on make transactions and add transaction mined period

Makefile

@@ -50,7 +50,7 @@ test-suite-runner:
 	make cancel
 
 ## Feed existing Swaplace contract with some transactions.
-## make mint
+## Requires a deployed Swaplace contract and mocks.
 transactions:
 	make mint
 	make approve

scripts/createSwap.ts

@@ -113,6 +113,9 @@ export async function main() {
   /// @dev Store the recently created swap and it's corresponding ID in the `.env` file.
   const swapId = await Swaplace.totalSwaps();
   await storeEnv(swapId, "SWAP_ID", tx.hash);
+
+  /// @dev Awaits for the transaction to be mined.
+  await tx.wait();
 }
 
 main().catch((error) => {

scripts/deploy.ts

@@ -35,6 +35,9 @@ async function main() {
 
   // @dev Store the contract address in the .env file.
   await storeEnv(Swaplace.address, "SWAPLACE_ADDRESS", true);
+
+  /// @dev Awaits for the transaction to be mined.
+  await Swaplace.deployed();
 }
 
 main().catch((error) => {

scripts/deployMock.ts

@@ -43,9 +43,13 @@ async function main() {
     MockERC721.deployTransaction.hash,
   );
 
-  // @dev Store the contract addresses in the .env file.
+  /// @dev Store the contract addresses in the .env file.
   await storeEnv(MockERC20.address, "ERC20_ADDRESS", true);
   await storeEnv(MockERC721.address, "ERC721_ADDRESS", true);
+
+  /// @dev Awaits for the transaction to be mined.
+  await MockERC20.deployed();
+  await MockERC721.deployed();
 }
 
 main().catch((error) => {

scripts/mint.ts

@@ -95,6 +95,10 @@ async function main() {
   );
 
   await storeEnv(tokenId, "TOKEN_ID", false);
+
+  /// @dev Awaits for the transaction to be mined.
+  await txErc20.wait();
+  await txErc721.wait();
 }
 
 main().catch((error) => {