Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: repo scripts section #197 #199

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

blackbeard002
Copy link
Contributor

closes #197

Copy link
Contributor

@0xneves 0xneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request ;)

package.json Outdated
"compile-echidna": "crytic-compile . && slither . --print echidna",
"fuzz-p": "echidna . --contract TestSwaplace --test-mode property --config echidna.config.yml",
"fuzz-a": "echidna . --contract TestSwaplace --test-mode assertion --config echidna.config.yml"
"fuzz-a": "echidna . --contract TestSwaplace --test-mode assertion --config echidna.config.yml",
"deploy:mocks": "npx hardhat run scripts/deployMock.ts --network $1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @blackbeard002 Could you please move line 37 before line 33 so that the scripts stay ordered by their category/alphabetic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye aye captain, I'm on it

@blackbeard002
Copy link
Contributor Author

Hey @0xneves made the changes as requested

Copy link
Contributor

@0xneves 0xneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Deepu!! Approving the changes! I will ask you to submit to develop from now on! Thank you

@0xneves 0xneves merged commit 1321fc8 into blockful-io:main Mar 8, 2024
3 checks passed
@blackbeard002 blackbeard002 deleted the scripts branch May 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: repo scripts section
2 participants