Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: repo scripts section #197

Closed
3 tasks
0xneves opened this issue Feb 20, 2024 · 2 comments · Fixed by #199
Closed
3 tasks

refactor: repo scripts section #197

0xneves opened this issue Feb 20, 2024 · 2 comments · Fixed by #199
Assignees
Labels
enhancement New feature or request

Comments

@0xneves
Copy link
Contributor

0xneves commented Feb 20, 2024

Feature Request

Describe the Feature Request

We want to make it easy for the command line to deploy the contracts in the repo to facilitate activities. This is part of a usability upgrade when running the swaplace-subgraph locally.

  • Change the deploy script name into deploy:swaplace
  • Add another script as deploy:mocks with the deployMoks.ts script
  • Remove the testnet script as it is ambiguous when simply using yarn test --network $1

Describe Preferred Solution

/* Remove */
 "testnet": "npx hardhat test --network $1",

/* Refactor */
 "deploy": "npx hardhat run scripts/deploy.ts --network $1",

 ---

 "deploy:swaplace": "npx hardhat run scripts/deploy.ts --network $1",
 "deploy:mocks": "npx hardhat run scripts/deployMocks.ts --network $1",

Related Code

package.json

@0xneves 0xneves added the enhancement New feature or request label Feb 20, 2024
@0xneves 0xneves added this to Swaplace Feb 20, 2024
@0xneves 0xneves moved this to 🔖 TODO in Swaplace Feb 20, 2024
@0xneves 0xneves added good first issue Good for newcomers and removed good first issue Good for newcomers labels Feb 20, 2024
blackbeard002 added a commit to blackbeard002/swaplace-contracts that referenced this issue Mar 5, 2024
@blackbeard002
Copy link
Contributor

Hey @0xneves made a PR that closes this #199

@0xneves
Copy link
Contributor Author

0xneves commented Mar 6, 2024

Hey @0xneves made a PR that closes this #199

I asked for a small refactor, take a look ;D

@0xneves 0xneves moved this from 🔖 TODO to 🕵️‍♀️ In Review in Swaplace Mar 6, 2024
blackbeard002 added a commit to blackbeard002/swaplace-contracts that referenced this issue Mar 6, 2024
0xneves added a commit that referenced this issue Mar 8, 2024
 refactor: repo scripts section #197
@heronlancellot heronlancellot moved this from 🕵️‍♀️ In Review to ✅ Done in Swaplace Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants