This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tradeservice implementation #2
base: develop
Are you sure you want to change the base?
tradeservice implementation #2
Changes from 4 commits
f55ea91
3cf5759
bb83d19
3faa2b1
2b2baef
fbea053
ac1ce4c
dd25621
6661d12
54dd86e
0784d62
ea94f4b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be the currencyMetadata
CurrencyMetaData(Integer scale, BigDecimal withdrawalFee)
of which we only have the scale and no other data .... so I left it in null.But I can build the currency with only the scale.