This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
tradeservice implementation #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvelazquez-bc
suggested changes
Jun 14, 2022
xchange-blockchain/src/main/java/org/knowm/xchange/blockchain/BlockchainAdapters.java
Outdated
Show resolved
Hide resolved
xchange-blockchain/src/main/java/org/knowm/xchange/blockchain/BlockchainAdapters.java
Outdated
Show resolved
Hide resolved
xchange-blockchain/src/main/java/org/knowm/xchange/blockchain/BlockchainAdapters.java
Outdated
Show resolved
Hide resolved
xchange-blockchain/src/main/java/org/knowm/xchange/blockchain/BlockchainAdapters.java
Outdated
Show resolved
Hide resolved
xchange-blockchain/src/main/java/org/knowm/xchange/blockchain/BlockchainAdapters.java
Outdated
Show resolved
Hide resolved
...ge-blockchain/src/test/java/org/knowm/xchange/blockchain/service/trade/TradeServiceTest.java
Outdated
Show resolved
Hide resolved
...-examples/src/main/java/org/knowm/xchange/examples/blockchain/trade/BlockchainTradeDemo.java
Outdated
Show resolved
Hide resolved
...-examples/src/main/java/org/knowm/xchange/examples/blockchain/trade/BlockchainTradeDemo.java
Outdated
Show resolved
Hide resolved
...-examples/src/main/java/org/knowm/xchange/examples/blockchain/trade/BlockchainTradeDemo.java
Outdated
Show resolved
Hide resolved
...-examples/src/main/java/org/knowm/xchange/examples/blockchain/trade/BlockchainTradeDemo.java
Outdated
Show resolved
Hide resolved
fvelazquez-bc
suggested changes
Jun 15, 2022
xchange-blockchain/src/main/java/org/knowm/xchange/blockchain/dto/trade/BlockchainOrder.java
Outdated
Show resolved
Hide resolved
...ge-blockchain/src/test/java/org/knowm/xchange/blockchain/service/trade/TradeServiceTest.java
Show resolved
Hide resolved
fvelazquez-bc
suggested changes
Jun 15, 2022
...ge-blockchain/src/main/java/org/knowm/xchange/blockchain/service/BlockchainTradeService.java
Outdated
Show resolved
Hide resolved
facundovs
suggested changes
Jun 15, 2022
xchange-blockchain/src/main/java/org/knowm/xchange/blockchain/BlockchainConstants.java
Outdated
Show resolved
Hide resolved
fvelazquez-bc
suggested changes
Jun 22, 2022
xchange-blockchain/src/main/java/org/knowm/xchange/blockchain/BlockchainAdapters.java
Outdated
Show resolved
Hide resolved
| .maximumAmount(maxAmount) | ||
| .build(); | ||
| currencyPairs.put(pair, currencyPairMetaData); | ||
| currency.put(entry.getValue().getBaseCurrency(), null); |
There was a problem hiding this comment.
There should be the currencyMetadata CurrencyMetaData(Integer scale, BigDecimal withdrawalFee) of which we only have the scale and no other data .... so I left it in null.
But I can build the currency with only the scale.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.