Wrap rust comments #512
Merged
Wrap rust comments #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 50.07% 50.08%
=======================================
Files 161 161
Lines 7874 7881 +7
=======================================
+ Hits 3943 3947 +4
- Misses 3931 3934 +3 ☔ View full report in Codecov by Sentry. |
dani-garcia
previously approved these changes
Jan 18, 2024
vgrassia
previously approved these changes
Jan 18, 2024
# Conflicts: # crates/bitwarden-generators/src/passphrase.rs # crates/bitwarden-generators/src/password.rs # crates/bitwarden/src/tool/generators/username_forwarders/forwardemail.rs
dani-garcia
previously approved these changes
Jan 19, 2024
dani-garcia
approved these changes
Jan 22, 2024
|
No New Or Fixed Issues Found |
vgrassia
approved these changes
Jan 22, 2024
coltonhurst
added a commit
that referenced
this pull request
Jan 29, 2024
Merged
coltonhurst
added a commit
that referenced
this pull request
Mar 25, 2024
## Type of change <!-- (mark with an `X`) --> ``` - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add a note about the required nightly toolchain. Without this people will receive an error when attempting to run the `build-api.sh` script. For posterity, the nightly toolchain is required for certain features deemed unsafe. You can find more info here: #512 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> - **README.md:** Add nightly install instructions ## Before you submit - Please add **unit tests** where it makes sense to do so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add a
rustfmt.tomlconfig with the following options:This sorts and groups imports. And wraps long comments. Unfortunately all of these configs are "unstable" and we need nightly cargo-fmt in order to run them.
Before you submit