SM-1091: Use rustfmt Nightly by Default

[coltonhurst]

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR is a proposal to add a rust-toolchain.toml file to the repository, and use rustfmt nightly by default due to #512.

Code changes

• rust-toolchain.toml: Adds this file

Before you submit

• Please add unit tests where it makes sense to do so

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3064ac5) 51.65% compared to head (88af9b7) 52.48%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   51.65%   52.48%   +0.82%     
==========================================
  Files         163      161       -2     
  Lines        8202     8113      -89     
==========================================
+ Hits         4237     4258      +21     
+ Misses       3965     3855     -110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dani-garcia]

I don't think there's a way to write a rust-toolchain file to force nightly rustfmt but stable compiler, which is what we should prefer to use, I think.

At the moment I changed my VSCode config to run nightly rustfmt: "rust-analyzer.rustfmt.extraArgs": "+nightly", and just use shell aliases for running cargo +nightly fmt, not great but it works.

[coltonhurst]

I don't think there's a way to write a rust-toolchain file to force nightly rustfmt but stable compiler, which is what we should prefer to use, I think.

At the moment I changed my VSCode config to run nightly rustfmt: "rust-analyzer.rustfmt.extraArgs": "+nightly", and just use shell aliases for running cargo +nightly fmt, not great but it works.

Bummer, was trying to experiment with this and see if there was a way to do it. Thanks for the tips, I'll use that!

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – 13fdfaaa-bc87-4fc5-ab61-499b04eea0b3

Fixed Issues

Severity	Issue	Source File / Package
	Command_Injection	/languages/python/example.py: 66
	Command_Injection	/languages/python/example.py: 35
	Missing User Instruction	/Dockerfile: 23
	Reflected_XSS	/languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 379
	Apt Get Install Pin Version Not Defined	/Dockerfile: 9
	Privacy_Violation	/languages/java/Example.java: 12
	Privacy_Violation	/languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 40
	Privacy_Violation	/languages/java/Example.java: 13
	Unchecked_Input_for_Loop_Condition	/languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 379
	Unpinned Actions Full Length Commit SHA	/build-cli-docker.yml: 151
	Unpinned Actions Full Length Commit SHA	/build-cli-docker.yml: 68
	Unpinned Actions Full Length Commit SHA	/release-cli.yml: 137
	Unpinned Actions Full Length Commit SHA	/release-cli.yml: 78
	Unpinned Actions Full Length Commit SHA	/release-napi.yml: 50
	Unpinned Actions Full Length Commit SHA	/publish-rust-crates.yml: 134
	Unpinned Actions Full Length Commit SHA	/release-napi.yml: 135
	Unpinned Actions Full Length Commit SHA	/build-cli-docker.yml: 75
	Unpinned Actions Full Length Commit SHA	/release-cli.yml: 61
	Unpinned Actions Full Length Commit SHA	/release-napi.yml: 104
	Unpinned Actions Full Length Commit SHA	/version-bump.yml: 52
	Using Platform Flag with FROM Command	/Dockerfile: 4
	Healthcheck Instruction Missing	/Dockerfile: 23
	Missing_CSP_Header	/about.hbs: 48