Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak ruby to not emit null in settings #432

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Tweak ruby to not emit null in settings #432

merged 1 commit into from
Dec 14, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 14, 2023

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Ruby emitted null in client settings which prevented rust from using the default implementation.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from dani-garcia December 14, 2023 12:14
@Hinton Hinton mentioned this pull request Dec 14, 2023
Closed
@Hinton Hinton merged commit a8ebf5a into main Dec 14, 2023
37 checks passed
@Hinton Hinton deleted the ps/ruby-null branch December 14, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hinton @dani-garcia