Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ClientSettings parsing #370

Closed
wants to merge 2 commits into from

Conversation

dani-garcia
Copy link
Member

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Remove null fields from the ClientSettings input, as serde deserializes the object correctly if the fields are unset, but not if they are explicitly null

@dani-garcia dani-garcia requested a review from Hinton November 30, 2023 12:15
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details8c251fde-80be-4fea-b348-7eb3488eb98c

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Reflected_XSS /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 294 Attack Vector
MEDIUM Unchecked_Input_for_Loop_Condition /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 294 Attack Vector

Fixed Issues

Severity Issue Source File / Package
HIGH Reflected_XSS /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 115
MEDIUM Unchecked_Input_for_Loop_Condition /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 115

@Hinton
Copy link
Member

Hinton commented Dec 14, 2023

Suggesting #432 instead of this. We can revisit if we find more needs for this.

@Hinton Hinton closed this Dec 14, 2023
@dani-garcia dani-garcia deleted the ps/improved-clientsettings-parse branch December 14, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants