Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SDK bindings examples #377

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Conversation

dani-garcia
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Updated all the samples to load access token, organization id and urls from env variables. This made it much easier to quickly test all the bindings. Also added one Java example.

@dani-garcia dani-garcia requested a review from Hinton December 1, 2023 17:05
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details3b4ed1d9-85f5-4565-af43-c44ca58c429d

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /languages/java/Example.java: 12 Attack Vector
MEDIUM Privacy_Violation /languages/java/Example.java: 13 Attack Vector
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 40 Attack Vector

Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPP has a comment about removing to use defaults, the others miss it. We should try and be consistent

@dani-garcia
Copy link
Member Author

Sounds good, I'm going to check that all the examples work correctly when not setting the URLs or setting them to null, we might need #370 for them all to work though.

@dani-garcia dani-garcia merged commit 7ec2183 into main Dec 14, 2023
39 checks passed
@dani-garcia dani-garcia deleted the ps/improve-bindings-examples branch December 14, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants