Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added section to note how we should handle changing Renovate PR #387

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

trmartin4
Copy link
Member

๐ŸŽŸ๏ธ Tracking

Feedback on handling of Renovate PRs

๐Ÿ“” Objective

It was unclear from our current process what the implications are to modifying a Renovate-generated PR. This change calls out the expectations for a reviewer if they do need to make manual changes so that we don't unintentionally prevent future dependency updates.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 requested a review from a team as a code owner July 18, 2024 17:38
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 63b5ae51-28cc-4bfe-bcd1-879bfd799b70

No New Or Fixed Issues Found

@trmartin4 trmartin4 merged commit 6855804 into main Jul 18, 2024
7 checks passed
@trmartin4 trmartin4 deleted the add-docs-for-renovate-pr-changes branch July 18, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants