Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the intended end of the sentence in the PR update section #388

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

trmartin4
Copy link
Member

🎟️ Tracking

Addressing typo in PR #387.

📔 Objective

Fixed typo in earlier PR that removed the end of the sentence.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 requested a review from a team as a code owner July 18, 2024 22:35
Copy link

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c16c8d
Status: ✅  Deploy successful!
Preview URL: https://6c938266.contributing-docs.pages.dev
Branch Preview URL: https://fix-missing-sentence.contributing-docs.pages.dev

View logs

Copy link

Logo
Checkmarx One – Scan Summary & Details3a1f989c-b197-4ee4-8d11-ac3d82b0f392

No New Or Fixed Issues Found

@djsmith85 djsmith85 merged commit 15324ad into main Jul 19, 2024
7 checks passed
@djsmith85 djsmith85 deleted the fix-missing-sentence branch July 19, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants