Hasan/Pr 1872 lighthouse v11 accessibility issue #5654
Conversation
hasan-deriv
requested review from
habib-deriv,
prince-deriv,
mitra-deriv and
fasihali-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deriv-com-git-fork-hasan-deriv-pr-1872-lhv11-accessibili-a709eb.binary.sx/ |
hasan-deriv
force-pushed
the
pr-1872-lhv11-accessibility-issue
branch
from
bbf8806 to
1aed7b4
Compare
hasan-deriv
force-pushed
the
pr-1872-lhv11-accessibility-issue
branch
from
863c02f to
608de55
Compare
| <Image | ||
| src={PartnerNavLogo} | ||
| className={partners_nav_logo} | ||
| alt="deriv partners logo" |
There was a problem hiding this comment.
@hasan-deriv shouldn't we localize all alt tags?
| @@ -137,7 +137,7 @@ const DCommonBanner = () => { | |||
| <StyledContainer jc="flex-start"> | |||
| <ContentWrapperStyle is_rtl={is_rtl}> | |||
| <Content> | |||
| <StyledTradingLogin src={DerivMT5Logo} /> | |||
| <StyledTradingLogin src={DerivMT5Logo} alt="Deriv MT5 logo" /> | |||
There was a problem hiding this comment.
i think we need translation for alt
| @@ -13,7 +13,7 @@ import useRegion from 'components/hooks/use-region' | |||
| const MarketTab = () => { | |||
| const [selected_market, setSelectedMarket] = useState<TAvailableLiveMarkets>('fx') | |||
| const [tab_name, setTabName] = useState('Forex') | |||
| const [linkToMarketPage, setLinkToMarketPage] = useState('/markets/forex/') | |||
| const [linkToMarketPage, setLinkToMarketPage] = useState<`/${string}`>('/markets/forex/') | |||
There was a problem hiding this comment.
this been used in several places , can we add this type in a common place
There was a problem hiding this comment.
TpathString = /${string}
Tstring
| selected={selected_tab === index} | ||
| aria-selected={selected_tab === index ? 'true' : 'false'} | ||
| aria-expanded={selected_tab === index ? 'true' : 'false'} |
There was a problem hiding this comment.
| aria-expanded={selected_tab === index ? 'true' : 'false'} | |
| aria-expanded={selected_tab === index} |
|
Kudos, SonarCloud Quality Gate passed!
|
Changes: