fix: careers accessibility

binary-com · Sep 22, 2023 · 863c02f · 863c02f
1 parent 113d87f
commit 863c02f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/features/components/templates/navigation/career-nav/index.tsx b/src/features/components/templates/navigation/career-nav/index.tsx
@@ -14,8 +14,12 @@ const CareerNav = () => {
     return (
         <NavTemplate
             renderLogo={() => (
-                <Link url={{ type: 'internal', to: '/' }}>
-                    <Image src={CareerNavLogo} className={careers_nav_logo} />
+                <Link url={{ type: 'internal', to: '/' }} aria-label="deriv careers logo link">
+                    <Image
+                        src={CareerNavLogo}
+                        className={careers_nav_logo}
+                        alt="deriv careers logo"
+                    />
                 </Link>
             )}
             items={career_nav_items}

diff --git a/src/features/components/templates/navigation/template/desktop-menu/index.tsx b/src/features/components/templates/navigation/template/desktop-menu/index.tsx
@@ -32,9 +32,11 @@ const DesktopMenu = ({ has_centered_items }: IDesktopNavbarProps) => {
                 ))}
                 {link_items.map((item) => (
                     <NavigationMenu.Item key={item.id} value={item.data.title} asChild>
-                        <NavigationMenu.Link asChild>
-                            <NavSingleItem item={item.data} />
-                        </NavigationMenu.Link>
+                        <li>
+                            <NavigationMenu.Link asChild>
+                                <NavSingleItem item={item.data} />
+                            </NavigationMenu.Link>
+                        </li>
                     </NavigationMenu.Item>
                 ))}
             </NavigationMenu.List>