Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 213 summary-always and gh-repository don't work together #214

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: 213 summary-always and gh-repository don't work together #214

merged 1 commit into from
Jan 25, 2024

Conversation

ktrz
Copy link
Member

@ktrz ktrz commented Jan 24, 2024

  • move summary logic into writeBenchmark function so that we only clone the separate repo once

fixes #213

@ktrz
fix: 213 summary-always and gh-repository don't work together
59978ac 
* move summary logic into writeBenchmark function so that we only clone repo once
@ktrz ktrz requested a review from ningziwen January 24, 2024 19:05
@ktrz ktrz self-assigned this Jan 24, 2024
@ningziwen ningziwen merged commit 029e9b8 into master Jan 25, 2024
21 checks passed
@ningziwen ningziwen deleted the fix/summary-does-not-work-with-separate-repo branch January 25, 2024 07:33
@ktrz ktrz mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ningziwen ningziwen ningziwen approved these changes

Assignees

@ktrz ktrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: when summary-always and gh-repository options don't work together
2 participants
@ktrz @ningziwen